Extension/Todos/tcOrder

* Fix order in which failings are reported and executed
* Change extension from `cur` to `real`
* Move todo out of extension.ts

src/core.ts

@@ -1,6 +1,7 @@
 'use strict';
+import * as vscode from 'vscode';
 import { mkdirSync, existsSync, copyFileSync, openSync, readSync, readdirSync, writeSync, closeSync } from "fs";
-import { dirname, join, extname } from "path";
+import { dirname, join, extname, basename } from "path";
 import * as child_process from 'child_process';
 import * as gwen from './gwen';
 import { TestcaseResult, Veredict, SolutionResult, Problem, Contest } from "./types";
@@ -10,9 +11,80 @@ export const TESTCASES = 'testcases';
 export const ATTIC = 'attic';
 const SRC = dirname(__filename);
 const TESTCASE_TIMEOUT = 1000;
-// TODO: Revisit this constant. Show specific error to know when this is an issue
+
+// TODO: 001
 const MAX_SIZE_INPUT = 1024;
 
+function isProblemFolder(path: string) {
+    return  existsSync(join(path, 'sol.cpp')) &&
+            existsSync(join(path, 'attic'));
+}
+
+function isTestcase(path: string){
+    let ext = extname(path);
+    return ext === '.in' || ext === '.out' || ext === '.real';
+}
+
+export function currentTestcase() {
+    let answer: string | undefined = undefined;
+
+    // Try to find an open testcase
+    if (vscode.window.activeTextEditor){
+        let path = vscode.window.activeTextEditor.document.uri.path;
+
+        if (isTestcase(path)){
+            answer = removeExtension(basename(path));
+        }
+    }
+
+    // Try to find the test case watching the current open workspace folder
+    if (vscode.workspace.workspaceFolders !== undefined){
+        vscode.workspace.workspaceFolders.forEach(function(fd){
+            if (answer === undefined && isTestcase(fd.uri.path)){
+                answer = removeExtension(basename(fd.uri.path));
+            }
+        });
+    }
+
+    // Test case not found
+    return answer;
+}
+
+export function currentProblem() {
+    // Try to find the problem using current open file
+    if (vscode.window.activeTextEditor){
+        let path = vscode.window.activeTextEditor.document.uri.path;
+
+        const MAX_DEPTH = 3;
+
+        for (let i = 0; i < MAX_DEPTH && !isProblemFolder(path); i++) {
+            path = dirname(path);
+        }
+
+        if (isProblemFolder(path)){
+            return path;
+        }
+    }
+
+    // Try to find the problem using the current open workspace folder
+    if (vscode.workspace.workspaceFolders !== undefined){
+        let path = vscode.workspace.workspaceFolders[0].uri.path;
+
+        const MAX_DEPTH = 1;
+
+        for (let i = 0; i < MAX_DEPTH && !isProblemFolder(path); i++) {
+            path = dirname(path);
+        }
+
+        if (isProblemFolder(path)){
+            return path;
+        }
+    }
+
+    // Problem not found
+    return undefined;
+}
+
 function createFolder(path: string){
     if (!existsSync(path)){
         createFolder(dirname(path));
@@ -139,7 +211,7 @@ export function newContestFromId(path: string, site: string, contestId: string |
 export function timedRun(path: string, tcName: string, timeout = TESTCASE_TIMEOUT){
     let tcInput = join(path, TESTCASES, `${tcName}.in`);
     let tcOutput = join(path, TESTCASES, `${tcName}.out`);
-    let tcCurrent = join(path, TESTCASES, `${tcName}.cur`);
+    let tcCurrent = join(path, TESTCASES, `${tcName}.real`);
 
     let inputFd = openSync(tcInput, 'r');
     let buffer = new Buffer(MAX_SIZE_INPUT);
@@ -184,7 +256,7 @@ export function timedRun(path: string, tcName: string, timeout = TESTCASE_TIMEOU
 }
 
 function compileCode(pathCode: string, pathOutput: string){
-    // # TODO: Avoid this hardcoded line. Use personalized compile line. increase stack by default
+    // TODO: 002
     return child_process.spawnSync("g++", ["-std=c++11", `${pathCode}`, "-o", `${pathOutput}`]);
 }
 
@@ -204,23 +276,36 @@ export function testSolution(path: string){
     }
 
     let testcasesId = testcasesName(path);
-    testcasesId.sort(); // Proccess all testcases in sorted order
+    // Proccess all testcases in sorted order
+    testcasesId.sort();
+
+    // Run current test case first (if it exists)
+    let startTc = currentTestcase();
+
+    if (startTc !== undefined){
+        testcasesId = testcasesId.reverse().filter(name => name !== startTc);
+        testcasesId.push(startTc);
+        testcasesId = testcasesId.reverse();
+    }
 
     let results = [];
-    let fail = undefined;
+    let fail: SolutionResult | undefined = undefined;
 
     testcasesId.forEach(tcId => {
-        let tcResult = timedRun(path, tcId);
+        // Run while there none have failed already
+        if (fail === undefined){
+            let tcResult = timedRun(path, tcId);
 
-        if (tcResult.status !== Veredict.OK){
-            fail = new SolutionResult(tcResult.status, tcId);
-        }
+            if (tcResult.status !== Veredict.OK){
+                fail = new SolutionResult(tcResult.status, tcId);
+            }
 
-        results.push(tcResult);
+            results.push(tcResult);
+        }
     });
 
     if (fail === undefined){
-        // TODO: IMPORTANT: Report max time and maybe other stats. Same with stress
+        // TODO: 003
         return new SolutionResult(Veredict.OK);
     }
     else{
@@ -229,7 +314,7 @@ export function testSolution(path: string){
 }
 
 function generateTestcase(path: string){
-    // TODO: NILOX: Revisit this call to python3. How to make it cross platform
+    // TODO: 004
     let genResult = child_process.spawnSync("python3", [join(path, ATTIC, 'gen.py')]);
 
     let currentFd = openSync(join(path, TESTCASES, 'gen.in'), 'w');
@@ -276,7 +361,7 @@ export function stressSolution(path: string, times: number = 10){
         closeSync(inputFd);
 
         // Run without restrictions
-        // TODO: EASY: Restrict brute in time, and capture errors
+        // TODO: 005
         let runResult = child_process.spawnSync(brout, {
             input: tcData,
         });
@@ -296,7 +381,6 @@ export function stressSolution(path: string, times: number = 10){
         history.push(result);
     }
 
-    // TODO: Check testSolution comment on this point
     return new SolutionResult(Veredict.OK);
 }
 

src/extension.ts

@@ -1,77 +1,14 @@
 'use strict';
-// The module 'vscode' contains the VS Code extensibility API
-// Import the module and reference it with the alias vscode in your code below
 import * as vscode from 'vscode';
 import { existsSync, writeFileSync, readdirSync } from 'fs';
-import { join, dirname, extname } from 'path';
+import { join, extname } from 'path';
 import { SITES } from './conn';
 import { newContestFromId, testSolution, veredictName, stressSolution, upgradeArena, newProblemFromId, removeExtension } from './core';
 import { Veredict } from './types';
-
-/**
- * TODO: When Compilation Error throw a better error.
- * TODO: Add How to Use (in the README.) adding own template etc...
- * TODO: Allow custom checker easily
- * TODO: Add several checkers and try to infer which is the correct! [*]
- * TODO: Smart ID detection while parsing ContestId & ProblemId [*]
- * TODO: Smart generator [*]
- * TODO: Find great name/slogan!!! other than acmhelper Competitive Programming made simple
- * TODO: Implement parser for codeforces to test on real cases
- * TODO: Learn how to move static files from `src` to `out`.
- * TODO: Allow programming in other languages than c++
- * TODO: IMPORTANT: Run testcases in sorted order
- * TODO: If a solution is run whith an open test, run that test first.
- * TODO: How to use behind proxy?
- * TODO: EASY: Change extension from `cur` to `real`
- *
- * TODO: When Runtime Error happens show as much output as possible and display the error in the console
- * TODO: Figure out something for interactive problems.
- *
- * [*] Machine Learning?
- */
+import { currentProblem } from './core';
 
 const TESTCASES = 'testcases';
 
-function isProblemFolder(path: string) {
-    return  existsSync(join(path, 'sol.cpp')) &&
-            existsSync(join(path, 'attic'));
-}
-
-function currentProblem() {
-    // Try to find the problem using current open file
-    if (vscode.window.activeTextEditor){
-        let path = vscode.window.activeTextEditor.document.uri.path;
-
-        const MAX_DEPTH = 3;
-
-        for (let i = 0; i < MAX_DEPTH && !isProblemFolder(path); i++) {
-            path = dirname(path);
-        }
-
-        if (isProblemFolder(path)){
-            return path;
-        }
-    }
-
-    // Try to find the problem using the current open workspace folder
-    if (vscode.workspace.workspaceFolders !== undefined){
-        let path = vscode.workspace.workspaceFolders[0].uri.path;
-
-        const MAX_DEPTH = 1;
-
-        for (let i = 0; i < MAX_DEPTH && !isProblemFolder(path); i++) {
-            path = dirname(path);
-        }
-
-        if (isProblemFolder(path)){
-            return path;
-        }
-    }
-
-    // Problem not found
-    return undefined;
-}
-
 function quickPickSites() {
     let sites: any[] = [];
 
@@ -104,7 +41,7 @@ async function addProblem() {
 
     let site = site_info.target;
 
-    // TODO: IMPORTANT: Provide custom problem id example in placeholder per different site
+    // TODO: 006
     let id = await vscode.window.showInputBox({placeHolder: "Problem ID"});
 
     if (id === undefined){
@@ -117,7 +54,7 @@ async function addProblem() {
     newProblemFromId(path, site, id);
 
     await vscode.commands.executeCommand("vscode.openFolder", vscode.Uri.file(path));
-    // TODO: How can I have access to new proccess created using `openFolder`?
+    // TODO: 007
     // Just want to run two commands below
     // await vscode.commands.executeCommand("vscode.open", vscode.Uri.file("sol.cpp"));
     // vscode.window.showInformationMessage(`Add problem ${site}/${id} at ${path}`);
@@ -161,7 +98,7 @@ async function addContest() {
         id = Number.parseInt(probCountStr!);
     }
     else{
-        // TODO: IMPORTANT: Provide custom contest id example in placeholder per different site
+        // TODO: 008
         id = await vscode.window.showInputBox({placeHolder: "Contest ID"});
 
         if (id === undefined){
@@ -184,9 +121,8 @@ async function debugTestcase(path: string, tcId: string){
     let sol = join(path, `sol.cpp`);
     let inp = join(path, TESTCASES, `${tcId}.in`);
     let out = join(path, TESTCASES, `${tcId}.out`);
-    let cur = join(path, TESTCASES, `${tcId}.cur`);
+    let cur = join(path, TESTCASES, `${tcId}.real`);
 
-    // TODO: How to clear opened tabs?
     await vscode.commands.executeCommand("vscode.open", vscode.Uri.file(sol), vscode.ViewColumn.One);
     await vscode.commands.executeCommand("vscode.open", vscode.Uri.file(inp), vscode.ViewColumn.Two);
     await vscode.commands.executeCommand("vscode.open", vscode.Uri.file(out), vscode.ViewColumn.Three);
@@ -290,7 +226,6 @@ async function coding() {
     await vscode.commands.executeCommand("vscode.open", vscode.Uri.file(sol), vscode.ViewColumn.One);
 }
 
-// TODO: Show time that the program took when it's ok
 async function stress(){
     let path = currentProblem();
 

src/parsers/codeforces.ts

@@ -1,6 +1,6 @@
 import { SiteDescription, Contest, Problem } from "../types";
 
-// TODO: Use sync requests
+// TODO: 009
 const request = require('request');
 
 /**

src/test/arena/exampleContest/B/testcases/1.cur

@@ -1 +0,0 @@
-8

src/test/arena/exampleContest/B/testcases/2.cur

@@ -1 +0,0 @@
-13

src/test/extension.test.ts

@@ -8,7 +8,7 @@ import * as assert from 'assert';
 import { dirname, join } from 'path';
 import { timedRun, testcasesName, testSolution, newArena, ATTIC, TESTCASES, upgradeArena, stressSolution, newProblemFromId, newContestFromId } from '../core';
 import { TestcaseResult, Veredict } from '../types';
-import { rmdirSync, existsSync, readdirSync, unlinkSync, openSync, writeSync, closeSync, readSync, fstat } from 'fs';
+import { rmdirSync, existsSync, readdirSync, unlinkSync, openSync, writeSync, closeSync, readSync } from 'fs';
 // import { request } from 'http';
 
 const SRC = join(dirname(dirname(dirname(__filename))), 'src', 'test');
@@ -90,7 +90,7 @@ suite("Extension Tests", function () {
         let result = testcasesName(path);
         let target = ["0", "1", "2"];
 
-        // TODO: How to check if two arrays are equal
+        // TODO: 010
         // I want to compare `result` & `target`
         target.forEach(name => {assert.notEqual(result.findIndex(tname => { return tname === name; }), -1);});
         result.forEach(name => {assert.notEqual(target.findIndex(tname => { return tname === name; }), -1);});
@@ -302,7 +302,6 @@ suite("Extension Tests", function () {
 
     test("downloading", async function(){
         let request = require('request');
-        // TODO: How to unittest an async call
         // let statusCode = undefined;
 
         await request('http://codeforces.com/contest/1081/problem/E', function(error: any, response: any, body: any){

todo.md

@@ -0,0 +1,29 @@
+# List of TODO
+
+* **IMPORTANT** When Compilation Error throw a better error. (maybe with runtime error too)
+* Add How to Use (in the README.) adding own template etc...
+* Allow custom checker easily
+* Add several checkers and try to infer which is the correct! [*]
+* Smart ID detection while parsing ContestId & ProblemId [*]
+* Smart generator [*]
+* Find great name/slogan!!! other than acmhelper Competitive Programming made simple
+* Implement parser for codeforces to test on real cases
+* Learn how to move static files from `src` to `out`.
+* Allow programming in other languages than c++
+* Refactor Code!!
+* When Runtime Error happens show as much output as possible and display the error in the console
+* Figure out something for interactive problems.
+* When a new view is activated (after run or view:code) close all open tabs. (maybe collapse everything not related to the problem)
+
+* [001](/src/core.ts): Revisit this constant. Show specific error to know when this is an issue
+* [002](/src/core.ts): Avoid this hardcoded line. Use personalized compile line. increase stack by default. This involve allowing different languages
+* [003](/src/core.ts): **IMPORTANT** Report max time and maybe other stats. (TestSolution, Stress)
+* [004](/src/core.ts): **NILOX** Revisit this call to python3. How to make it cross platform
+* [005](/src/core.ts): Restrict brute in time, and capture errors
+* [006](/src/extension.ts): **IMPORTANT** Provide custom problem id example in placeholder per different site
+* [007](/src/extension.ts): How can I have access to new proccess created using `openFolder`?
+* [008](/src/extension.ts): **IMPORTANT** Provide custom contest id example in placeholder per different site
+* [009](/src/parsers/codeforces.ts): Use sync requests
+* [010](/src/test/extension.test.ts): How to check if two arrays are equal
+
+[*] Machine Learning?